Skip to content

Encore: configure runtime environment if not already configured #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Jun 1, 2019

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented May 27, 2019

Q A
License MIT

With this, we directly fix the error:

Encore.setOutputPath() cannot be called yet because the runtime environment
doesn't appear to be configured. Make sure you're using the encore executable
or call Encore.configureRuntimeEnvironment() first if you're purposely not
calling Encore directly.

when using Encore/Webpack without the encore command (npm run encore ...).

This is useful when:

  • using tools that depends of webpack.config.js, like ESLint with the import plugin, Karma, ...
  • using an IDE with Webpack integration

This doesn't break anything if you use encore command, since it already configure the runtime environment.

See:

What do you think about it?
Thanks :)

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@ghost ghost merged commit 3c583b5 into symfony:master Jun 1, 2019
ghost pushed a commit that referenced this pull request Jun 1, 2019
@Kocal Kocal deleted the patch-1 branch June 1, 2019 15:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants