Make use of the local phpunit.xsd #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
Pierstoval
suggested changes
Sep 30, 2019
There was a problem hiding this comment.
It won't work for symfony/simple-phpunit because phpunit is not required in composer.json and therefore not installed in the vendor dir.
The bin/phpunit file states that it's installed in bin/.phpunit/phpunit-{version}/, therefore the version should be changed in the bridge's xml files.
julienfalque
force-pushed
the
local-phpunit-xsd
branch
from
6d901c3 to
3132df9
Compare
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Sep 30, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Copy phpunit.xsd to a predictable path | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes-ish | Deprecations? | no | Tickets | symfony/recipes#652 (comment) | License | MIT | Doc PR | - In symfony/recipes#652 I would like to make Flex create the `phpunit.xml.dist` file with a local URI for the `phpunit.xsd`. This is doable when using `phpunit/phpunit` standalone because the path to the XSD file is known. This PR aims to allow doing this when using the PHPUnit Bridge, which installs PHPUnit in a path that might change. Is is simple `@copy()` call ok? Should I add some error handling? Commits ------- 233dcb4 Copy phpunit.xsd to a predictable path
nicolas-grekas
approved these changes
Oct 26, 2019
fabpot
approved these changes
Oct 26, 2019
|
This is so good. Thanks for the idea. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the local
phpunit.xsdfile guarantees we use the exact version that is installed. It also improves DX with PhpStorm as it becomes able to validatephpunit.xmlwithout manually registering XSD file's URI.