Add a Github PR template #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symfony-bot
previously approved these changes
May 14, 2017
|
What's the purpose of this template? If "contrib" accepts any license, we wouldn't need it. And if "contrib" doesn't accept all licenses, shouldn't we instead add a message explaining which licenses do we accept? Thanks! |
|
Indeed, you're right, I will add the template and only keep the comment. |
symfony-bot
approved these changes
May 14, 2017
javiereguiluz
approved these changes
May 14, 2017
xabbuh
approved these changes
May 15, 2017
fabpot
added a commit
that referenced
this pull request
May 15, 2017
This PR was merged into the master branch. Discussion ---------- Add a Github PR template Commits ------- a572667 added a PR template
VolCh
pushed a commit
to VolCh/recipes
that referenced
this pull request
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.