-
-
Notifications
You must be signed in to change notification settings - Fork 497
Use configureBabelPresetEnv() in webpack.config.js #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
@Lyrkan Do you have any strong preference? |
I'm fine with both ways, as long as we don't also set other non-preset-env Babel options (since it would then need two different calls). The version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
Oh, I missed that. I've updated the |
Use
configureBabelPresetEnv()
introduced in symfony/webpack-encore#642 instead ofconfigureBabel()
.