Skip to content

Use configureBabelPresetEnv() in webpack.config.js #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Dec 8, 2019
Merged

Use configureBabelPresetEnv() in webpack.config.js #702

1 commit merged into from
Dec 8, 2019

Conversation

ihmels
Copy link
Contributor

@ihmels ihmels commented Dec 6, 2019

Q A
License MIT
Doc issue/PR n/a

Use configureBabelPresetEnv() introduced in symfony/webpack-encore#642 instead of configureBabel().

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@ihmels ihmels changed the title Use configureBabelPresetEnv() Use configureBabelPresetEnv() in webpack.config.js Dec 6, 2019
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@weaverryan
Copy link
Member

@Lyrkan Do you have any strong preference?

@Lyrkan
Copy link
Contributor

Lyrkan commented Dec 7, 2019

I'm fine with both ways, as long as we don't also set other non-preset-env Babel options (since it would then need two different calls).

The version of @symfony/webpack-encore included in the recipe should however probably be bumped to ^0.28.2 if we go with that one. Even though it doesn't really matter (people using the recipe should get the latest allowed version) the current range also allows 0.28.0 and 0.28.1 in which Encore.configureBabelPresetEnv() was not available/didn't work.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@ihmels
Copy link
Contributor Author

ihmels commented Dec 8, 2019

The version of @symfony/webpack-encore included in the recipe should however probably be bumped to ^0.28.2 if we go with that one.

Oh, I missed that. I've updated the package.json.

ghost pushed a commit that referenced this pull request Dec 8, 2019
@ghost ghost merged commit a3e45d6 into symfony:master Dec 8, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants