Add secret env to framework configuration #781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
|
I meant the whole config/packages directory should be linked :) |
|
@nicolas-grekas oh sorry I see. its fixed now! |
nicolas-grekas
approved these changes
Jun 8, 2020
fabpot
approved these changes
Jun 9, 2020
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jun 9, 2020
…ernelTrait (nicolas-grekas) This PR was merged into the 5.1 branch. Discussion ---------- [FrameworkBundle] Remove reference to APP_SECRET in MicroKernelTrait | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #37123 | License | MIT | Doc PR | - Needs symfony/recipes#781 Commits ------- bf0b48a [FrameworkBundle] Remove reference to APP_SECRET in MicroKernelTrait
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
APP_SECRETis defined but never set to the framework configuration.