Skip to content

[nelmio/cors-bundle] Fix CORS_ALLOW_ORIGIN format #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Dec 27, 2020
Merged

[nelmio/cors-bundle] Fix CORS_ALLOW_ORIGIN format #849

1 commit merged into from
Dec 27, 2020

Conversation

yannoff
Copy link
Contributor

@yannoff yannoff commented Nov 24, 2020 •
edited by chalasr
Loading

  • Wrap value between simple quotes: avoid shell error when sourcing .env file
Q A
License MIT
Doc issue/PR -

Fixes #848

@yannoff
[nelmio/cors-bundle] Fix CORS_ALLOW_ORIGIN format
ed11407 
- Wrap value between simple quotes: avoid shell error when sourcing `.env` file
ghost
ghost approved these changes Nov 24, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Dec 20, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Nyholm
Nyholm approved these changes Dec 27, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ghost ghost merged commit 4b0b80c into symfony:master Dec 27, 2020
@yannoff yannoff mentioned this pull request Dec 28, 2020
Closed
@yannoff yannoff mentioned this pull request Feb 4, 2021
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstok sstok sstok approved these changes

@Nyholm Nyholm Nyholm approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[nelmio/cors-bundle] Malformed shell syntax for CORS_ALLOW_ORIGIN recipe defaults
4 participants
@yannoff @sstok @Nyholm @chalasr