Skip to content

Add symfony/gatewayapi-notifier #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Jan 15, 2021
Merged

Add symfony/gatewayapi-notifier #864

1 commit merged into from
Jan 15, 2021

Conversation

OskarStark
Copy link
Contributor

Q A
License MIT
Doc issue/PR symfony/symfony#39568

ghost
ghost suggested changes Dec 20, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@OskarStark OskarStark mentioned this pull request Dec 20, 2020
Merged
OskarStark added a commit to symfony/symfony that referenced this pull request Jan 14, 2021
@OskarStark
feature #39568 [Notifier] Add GatewayApi bridge (Piergiuseppe Longo)
e55762d 
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Notifier] Add GatewayApi bridge

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Replaces #38685
| License       | MIT
| Doc PR        | symfony/symfony-docs#14463
| Recipe PR        | symfony/recipes#864

Initial PR by @PGLongo

Commits
-------

6b9f721 [Notifier] Add GatewayApi bridge
@OskarStark
Copy link
Contributor Author

friendly ping @fabpot

@fabpot
Copy link
Member

fabpot commented Jan 15, 2021

@symfony-flex-server review again please

ghost
ghost approved these changes Jan 15, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

fabpot
fabpot approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge now

@ghost ghost merged commit 0595ace into symfony:master Jan 15, 2021
@OskarStark OskarStark deleted the gatewayapi-5.3 branch January 15, 2021 11:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OskarStark @fabpot