Skip to content

Updating package.json and bootstrap.js for upcoming stimulus-bridge #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
2 commits merged into from
Feb 3, 2021
Merged

Updating package.json and bootstrap.js for upcoming stimulus-bridge #883

2 commits merged into from
Feb 3, 2021

Conversation

weaverryan
Copy link
Member

@weaverryan weaverryan commented Jan 23, 2021 •
edited
Loading

Q A
License MIT
Doc issue/PR It appears nothing is needed

This is waiting on:

This affects all version of WebpackEncoreBundle... but it's an odd case where the bundle and Webpack encore itself are not very "bound" together. We could update this recipe in only the latest WebpackEncoreBundle version... or even bump a new minor version of the bundle and add it there. This relates to https://github.com/symfony/recipes#updating-recipes

ghost
ghost approved these changes Jan 23, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Jan 23, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

OskarStark
OskarStark reviewed Jan 24, 2021
View reviewed changes
ghost
ghost approved these changes Jan 26, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Jan 26, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@weaverryan weaverryan mentioned this pull request Jan 27, 2021
Merged
@weaverryan weaverryan changed the title [WIP] bumping to Encore 1.0 & latest stimulus-bridge [WIP] Updating package.json and bootstrap.js for upcoming stimulus-bridge Jan 27, 2021
ghost
ghost approved these changes Jan 27, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@stof stof mentioned this pull request Jan 28, 2021
Closed
ghost
ghost approved these changes Jan 28, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@weaverryan
bumping to latest stimulus-bridge
e4b2331 
Removing auto-import and adding new lazy-controller-loader
ghost
ghost approved these changes Jan 29, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Feb 1, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Feb 2, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Feb 2, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Feb 2, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@weaverryan weaverryan changed the title [WIP] Updating package.json and bootstrap.js for upcoming stimulus-bridge Updating package.json and bootstrap.js for upcoming stimulus-bridge Feb 2, 2021
ghost
ghost approved these changes Feb 2, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@weaverryan weaverryan changed the title Updating package.json and bootstrap.js for upcoming stimulus-bridge [WIP] Updating package.json and bootstrap.js for upcoming stimulus-bridge Feb 2, 2021
ghost
ghost approved these changes Feb 2, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Feb 2, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@jmsche
Copy link
Contributor

jmsche commented Feb 3, 2021

Hi, is it possible to merge this? Bridge 2.0 was tagged yesterday, and so was UX 1.2.0, so it would help a lot for new installs.

@weaverryan weaverryan changed the title [WIP] Updating package.json and bootstrap.js for upcoming stimulus-bridge Updating package.json and bootstrap.js for upcoming stimulus-bridge Feb 3, 2021
ghost
ghost approved these changes Feb 3, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Feb 3, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@weaverryan
Copy link
Member Author

I'm getting it merged now - the UX individual packages (despite the tag timestamp) weren't pushed until a few hours ago. I was waiting until then - but we're good now!

Nyholm
Nyholm approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ghost ghost merged commit f7ee6c3 into symfony:master Feb 3, 2021
@weaverryan weaverryan deleted the encore-1.0 branch February 3, 2021 11:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@weaverryan @jmsche @fabpot @OskarStark @Nyholm