switching var to const to be more modern #886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
stof
approved these changes
Jan 28, 2021
nicolas-grekas
approved these changes
Jan 28, 2021
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Feb 5, 2021
This PR was squashed before being merged into the 5.2 branch. Discussion ---------- updating Encore docs for 1.0 Hi! I do an entire, quick read-through of the docs and updated for 1.0 (and modernized a few spots - like `var` -> `const` - symfony/recipes#886 Cheers! Commits ------- a85f968 updating Encore docs for 1.0
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally (4 years ago) used
varbecauseconstwere still relatively new and not necessarily known widely. I think that's not true anymore, so let's use the more modern `const.Cheers!