Skip to content

Add a recipe to ease installation of Blackfire #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Add a recipe to ease installation of Blackfire #993

merged 1 commit into from
Aug 31, 2021

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Aug 31, 2021

Q A
License MIT
Doc issue/PR symfony/symfony-docs#...

@github-actions
Copy link

github-actions bot commented Aug 31, 2021

Diff between recipe versions

Thanks for the PR 😍

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@@ -0,0 +1,7 @@
* Blackfire Agent has been configured in your <comment>docker-compose.yaml</> file

* Configure your Blackfire <comment>SERVER</> credentials in <info>.env.local</> (get them at https://blackfire.io/my/settings/credentials)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be more explicit here, not to confuse people with environment credentials

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it, we'd better keep this link.
Available credentials (for Blackfire environments and personal server credentials) should probably get listed in the Blackfire settings page.
Ping @ChristopheDujarric

@fabpot fabpot merged commit f3b1d14 into master Aug 31, 2021
@fabpot fabpot deleted the blackfire branch August 31, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants