Skip to content

"autoincrement" is a boolean, fix #43 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

sandermarechal
Copy link

Fixes #43 which causes unwanted schema differences when using DBAL 2.9.0 with security-acl 3.x

@fabpot
Copy link
Member

fabpot commented Dec 13, 2018

Thank you @sandermarechal.

@fabpot fabpot merged commit e610abf into symfony:master Dec 13, 2018
fabpot added a commit that referenced this pull request Dec 13, 2018
This PR was merged into the 3.0-dev branch.

Discussion
----------

"autoincrement" is a boolean, fix #43

Fixes #43 which causes unwanted schema differences when using DBAL 2.9.0 with security-acl 3.x

Commits
-------

e610abf "autoincrement" is a boolean, fix #43
@acrobat
Copy link
Contributor

acrobat commented Feb 12, 2019

@fabpot is possible to tag a new release with this fix? Dbal 2.9 + acl-bundle 3.x keeps on generating schema changes on each doctrine migration diff. Thanks!

@acrobat
Copy link
Contributor

acrobat commented Apr 15, 2019

@fabpot @nicolas-grekas would it be possible to have this fix included in a new release? Would be nice because with Dbal 2.9 + acl-bundle 3.x it will generate noise in the db diffs of doctrine

$this->addSql('ALTER TABLE acl_classes CHANGE id id INT UNSIGNED AUTO_INCREMENT NOT NULL');
$this->addSql('ALTER TABLE acl_security_identities CHANGE id id INT UNSIGNED AUTO_INCREMENT NOT NULL');
$this->addSql('ALTER TABLE acl_object_identities CHANGE id id INT UNSIGNED AUTO_INCREMENT NOT NULL');
$this->addSql('ALTER TABLE acl_entries CHANGE id id INT UNSIGNED AUTO_INCREMENT NOT NULL');

Thanks!

@fabpot
Copy link
Member

fabpot commented Apr 15, 2019

I've just released v3.0.2.

@sandermarechal sandermarechal deleted the autoincrement-3.0 branch April 15, 2019 10:14
@acrobat
Copy link
Contributor

acrobat commented Apr 15, 2019

Thanks a lot @fabpot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BC break with Doctrine DBAL 2.9.0
4 participants