Skip to content

allow phpdocumentor/reflection-docblock 5 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2020
Merged

allow phpdocumentor/reflection-docblock 5 #2

merged 1 commit into from
Mar 28, 2020

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 27, 2020

No description provided.

@xabbuh xabbuh mentioned this pull request Mar 27, 2020
Closed
Nyholm
Nyholm approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog show a bump in PHP version as far as I can see

@xabbuh
Copy link
Member Author

xabbuh commented Mar 27, 2020

@Nyholm That's fine, Composer will choose a version of the package matching the PHP version locally installed.

@Nyholm
Copy link
Member

Nyholm commented Mar 27, 2020

Yes. I just wanted to make sure there were no BC breaks in the API.

Im 👍

nicolas-grekas
nicolas-grekas reviewed Mar 27, 2020
View reviewed changes
composer.json Outdated
@@ -6,7 +6,7 @@
"require": {
"php": "^7.0",
"doctrine/annotations": "^1.0",
"phpdocumentor/reflection-docblock": "^3.0|^4.0",
"phpdocumentor/reflection-docblock": "^3.0|^4.0|^5.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a fan of *.

Restrictions are good. =)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency also ;)

Copy link
Member

@nicolas-grekas nicolas-grekas Mar 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Joke apart, I don't like that packs add their own constraints, that's why I prefer a *. Ppl that need better control should unpack.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. That is fair.

I’m okey with * but only because this is a pack. Other packages (that require the documentor) need to have “real” versions specified in their dependencies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference is that other * constraints won't actually run as * in a Flex project, as they are filtered by the Symfony Flex constraint. This one is really a *.

@fabpot
Copy link
Member

fabpot commented Mar 28, 2020

Thank you @xabbuh.

@fabpot fabpot merged commit 9bbce72 into symfony:master Mar 28, 2020
@xabbuh xabbuh deleted the patch-1 branch March 28, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@stof stof stof left review comments

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @Nyholm @fabpot @nicolas-grekas @stof