This repository was archived by the owner on Feb 6, 2022. It is now read-only.
Added alternative mail formats view #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a foreach on swiftmailer message parts to display also the alternate text/html text/plain version of the message.
fabpot
added a commit
that referenced
this pull request
Mar 25, 2013
This PR was merged into the master branch. Discussion ---------- Added alternative mail formats view I've added a foreach on swiftmailer message parts to display also the alternate text/html text/plain version of the message. Commits ------- 750f809 Added alternative mail formats view
| <p> | ||
| <pre> | ||
| {%- if messagePart.charset %} | ||
| {{- messagePart.body|e('html', messagePart.charset)|convert_encoding('UTF-8', messagePart.charset) }} |
There was a problem hiding this comment.
wouldn't this be escaped a second time by the auto-escaper ?
There was a problem hiding this comment.
You're right, should I just remove the escaping or also the convert_encoding?
Also, why does it escapes 2 times? Isn't it escaped as the main body?
There was a problem hiding this comment.
you are escaping it once explicitly, and converting the charset (which is not a filter marked as safe for the auto-escaper) and the auto-escaper escapes it again.
You should remove the e filter IMO (and also in the else part)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a foreach on swiftmailer message parts to display also the alternate text/html text/plain version of the message.