Skip to content
This repository was archived by the owner on Feb 6, 2022. It is now read-only.

fix OutOfBoundsException when using mail or sendmail transport #42

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions DependencyInjection/SwiftmailerExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -134,11 +134,24 @@ protected function configureMailerTransport($name, array $mailer, ContainerBuild
->addMethodCall('setSourceIp', array('%swiftmailer.mailer.' . $name . '.transport.smtp.source_ip%'))
;
$container->setAlias(sprintf('swiftmailer.mailer.%s.transport', $name), sprintf('swiftmailer.mailer.%s.transport.%s', $name, $transport));
} elseif (in_array($transport, array('mail', 'sendmail'))) {
} elseif ('sendmail' === $transport) {
$definitionDecorator = new DefinitionDecorator(sprintf('swiftmailer.transport.%s.abstract', $transport));
$container
->setDefinition(sprintf('swiftmailer.mailer.%s.transport.%s', $name, $transport), $definitionDecorator)
->replaceArgument(1, new Reference(sprintf('swiftmailer.mailer.%s.transport.eventdispatcher', $name)))
->setArguments(array(
new Reference('swiftmailer.transport.buffer'),
new Reference(sprintf('swiftmailer.mailer.%s.transport.eventdispatcher', $name)),
))
;
$container->setAlias(sprintf('swiftmailer.mailer.%s.transport', $name), sprintf('swiftmailer.mailer.%s.transport.%s', $name, $transport));
} elseif ('mail' === $transport) {
$definitionDecorator = new DefinitionDecorator(sprintf('swiftmailer.transport.%s.abstract', $transport));
$container
->setDefinition(sprintf('swiftmailer.mailer.%s.transport.%s', $name, $transport), $definitionDecorator)
->setArguments(array(
new Reference('swiftmailer.transport.mailinvoker'),
new Reference(sprintf('swiftmailer.mailer.%s.transport.eventdispatcher', $name)),
))
;
$container->setAlias(sprintf('swiftmailer.mailer.%s.transport', $name), sprintf('swiftmailer.mailer.%s.transport.%s', $name, $transport));
} elseif ('null' === $transport) {
Expand Down
4 changes: 4 additions & 0 deletions Tests/DependencyInjection/Fixtures/config/php/mail.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<?php
$container->loadFromExtension('swiftmailer', array(
'transport' => "mail",
));
4 changes: 4 additions & 0 deletions Tests/DependencyInjection/Fixtures/config/php/sendmail.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<?php
$container->loadFromExtension('swiftmailer', array(
'transport' => "sendmail",
));
12 changes: 12 additions & 0 deletions Tests/DependencyInjection/Fixtures/config/xml/mail.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?xml version="1.0" encoding="UTF-8" ?>
<container xmlns="http://symfony.com/schema/dic/services"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns:swiftmailer="http://symfony.com/schema/dic/swiftmailer"
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd
http://symfony.com/schema/dic/swiftmailer http://symfony.com/schema/dic/swiftmailer/swiftmailer-1.0.xsd">


<swiftmailer:config
transport="mail"
/>
</container>
12 changes: 12 additions & 0 deletions Tests/DependencyInjection/Fixtures/config/xml/sendmail.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?xml version="1.0" encoding="UTF-8" ?>
<container xmlns="http://symfony.com/schema/dic/services"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns:swiftmailer="http://symfony.com/schema/dic/swiftmailer"
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd
http://symfony.com/schema/dic/swiftmailer http://symfony.com/schema/dic/swiftmailer/swiftmailer-1.0.xsd">


<swiftmailer:config
transport="sendmail"
/>
</container>
2 changes: 2 additions & 0 deletions Tests/DependencyInjection/Fixtures/config/yml/mail.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
swiftmailer:
transport: mail
2 changes: 2 additions & 0 deletions Tests/DependencyInjection/Fixtures/config/yml/sendmail.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
swiftmailer:
transport: sendmail
22 changes: 22 additions & 0 deletions Tests/DependencyInjection/SwiftmailerExtensionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,28 @@ public function testDefaultConfig($type)
$this->assertEquals('swiftmailer.mailer.default.transport.smtp', (string) $container->getAlias('swiftmailer.mailer.default.transport'));
}

/**
* @dataProvider getConfigTypes
*/
public function testSendmailConfig($type)
{
$container = $this->loadContainerFromFile('sendmail', $type);

$this->assertEquals('swiftmailer.mailer.default.transport', (string) $container->getAlias('swiftmailer.transport'));
$this->assertEquals('swiftmailer.mailer.default.transport.sendmail', (string) $container->getAlias('swiftmailer.mailer.default.transport'));
}

/**
* @dataProvider getConfigTypes
*/
public function testMailConfig($type)
{
$container = $this->loadContainerFromFile('mail', $type);

$this->assertEquals('swiftmailer.mailer.default.transport', (string) $container->getAlias('swiftmailer.transport'));
$this->assertEquals('swiftmailer.mailer.default.transport.mail', (string) $container->getAlias('swiftmailer.mailer.default.transport'));
}

/**
* @dataProvider getConfigTypes
*/
Expand Down