Skip to content

Commit 6bea51d

Browse files
committed
minor #18143 [Standards] Remove additional comma (alexandre-daubois)
This PR was merged into the 5.4 branch. Discussion ---------- [Standards] Remove additional comma DOCtor-RST is unhappy about backticks escaping (see the failing CI task). Wanted to fix it as well but the documentation rendered successfully in https://symfony.com/doc/current/contributing/code/standards.html, so I'm not sure we should take this warning in account 🤔 Commits ------- c6a4e45 [Standards] Remove additional comma
2 parents 754fc82 + c6a4e45 commit 6bea51d

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

contributing/code/standards.rst

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,9 +179,14 @@ Structure
179179

180180
* Exception and error message strings must be concatenated using :phpfunction:`sprintf`;
181181

182-
* Exception and error messages must not contain backticks (e.g. 'The \`foo\` option ...'),
182+
* Exception and error messages must not contain backticks,
183183
even when referring to a technical element (such as a method or variable name).
184-
Double quotes must be used at all time (e.g. 'The "foo" option ...'),;
184+
Double quotes must be used at all time:
185+
186+
.. code-block:: diff
187+
188+
- Expected `foo` option to be one of ...
189+
+ Expected "foo" option to be one of ...
185190
186191
* Exception and error messages must start with a capital letter and finish with a dot ``.``;
187192

0 commit comments

Comments
 (0)