[Standards] Remove additional comma #18143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Mar 30, 2023
|
Can you add this line to the whitelist in |
alexandre-daubois
force-pushed
the
additional-comma
branch
2 times, most recently
from
f5d232a to
ac504e0
Compare
OskarStark
reviewed
Mar 30, 2023
alexandre-daubois
force-pushed
the
additional-comma
branch
2 times, most recently
from
302245b to
0b12a5e
Compare
|
Please check Slack 😄 Thanks |
alexandre-daubois
force-pushed
the
additional-comma
branch
5 times, most recently
from
9ee8c83 to
9628714
Compare
alexandre-daubois
force-pushed
the
additional-comma
branch
from
9628714 to
c6a4e45
Compare
OskarStark
approved these changes
Mar 30, 2023
|
Thank you @alexandre-daubois. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOCtor-RST is unhappy about backticks escaping (see the failing CI task).
Wanted to fix it as well but the documentation rendered successfully in https://symfony.com/doc/current/contributing/code/standards.html, so I'm not sure we should take this warning in account 🤔