Skip to content

Commit 990087a

Browse files
committed
minor #15818 Update pull_requests.rst (gnito-org)
This PR was submitted for the 5.3 branch but it was squashed and merged into the 4.4 branch instead. Discussion ---------- Update pull_requests.rst Removing the outdated references to Travis-CI. It was confusing when I tried to get up to speed on contributing. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `5.x` for features of unreleased versions). --> Commits ------- 222875b Update pull_requests.rst
2 parents 9016310 + 222875b commit 990087a

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

contributing/code/pull_requests.rst

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -107,12 +107,6 @@ Check that the current Tests Pass
107107
Now that Symfony is installed, check that all unit tests pass for your
108108
environment as explained in the dedicated :doc:`document <tests>`.
109109

110-
.. tip::
111-
112-
If tests are failing, check on `Travis-CI`_ if the same test is
113-
failing there as well. In that case you do not need to be concerned
114-
about the test failing locally.
115-
116110
.. _step-2-work-on-your-patch:
117111

118112
Step 3: Work on your Pull Request
@@ -252,7 +246,7 @@ in mind the following:
252246
as defined in `PSR-1`_ and `PSR-2`_.
253247

254248
A status is posted below the pull request description with a summary
255-
of any problems it detects or any `Travis-CI`_ build failures.
249+
of any problems it detects or any GitHub Actions build failures.
256250

257251
.. _prepare-your-patch-for-submission:
258252

@@ -533,6 +527,5 @@ before merging.
533527
.. _`PSR-2`: https://www.php-fig.org/psr/psr-2/
534528
.. _`searching on GitHub`: https://github.com/symfony/symfony/issues?q=+is%3Aopen+
535529
.. _`Symfony Slack`: https://symfony.com/slack-invite
536-
.. _`Travis-CI`: https://travis-ci.org/symfony/symfony
537530
.. _`Psalm phar is installed`: https://psalm.dev/docs/running_psalm/installation/
538531
.. _`Contributing Back To Symfony`: https://symfonycasts.com/screencast/contributing

0 commit comments

Comments
 (0)