Skip to content

[Messenger] Minor wording tweak regarding factories #10019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2018

Conversation

ogizanagi
Copy link
Contributor

As an end-user, the following DI config isn't the one for using a middleware factory but for defining one using DI config instead.
Using an existing configurable middleware is described below in a messenger config sample.

As an end-user, the following DI config isn't the one for __using__ a middleware factory but for defining one using DI config instead.
Using an existing configurable middleware is described below in a `messenger` config sample.
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -609,7 +609,7 @@ Using Middleware Factories
~~~~~~~~~~~~~~~~~~~~~~~~~~

Some third-party bundles and libraries provide configurable middleware via
factories. Using them requires a two-step configuration based on Symfony's
factories. Defining such requires a two-step configuration based on Symfony's
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also remove the 'sbtw: Symfony features.

@HeahDude HeahDude added this to the 4.1 milestone Jul 5, 2018
@javiereguiluz
Copy link
Member

Thanks Maxime.

@javiereguiluz javiereguiluz merged commit 63830ab into symfony:4.1 Jul 5, 2018
javiereguiluz added a commit that referenced this pull request Jul 5, 2018
…zanagi)

This PR was merged into the 4.1 branch.

Discussion
----------

[Messenger] Minor wording tweak regarding factories

As an end-user, the following DI config isn't the one for __using__ a middleware factory but for defining one using DI config instead.
Using an existing configurable middleware is described below in a `messenger` config sample.

Commits
-------

63830ab [Messenger] Minor wording tweak regarding factories
@ogizanagi ogizanagi deleted the patch-3 branch July 5, 2018 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants