Skip to content

remove reference to Assetic #10040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 10, 2018

No description provided.

@xabbuh xabbuh added this to the 4.0 milestone Jul 10, 2018
@xabbuh
Copy link
Member Author

xabbuh commented Jul 10, 2018

At the end of the document we have this:

.. toctree::
    :maxdepth: 1
    :glob:

    frontend/*

This will include the frontend/assetic.rst file too. We should remove that too. Is it possible to exclude a file from the toctree? Otherwise, we will need to list all files to be actually included explicitly.

@javiereguiluz
Copy link
Member

Try this, but I haven't tested it myself:

.. toctree::
    :hidden:

    frontend/assetic.rst

.. toctree::
    :maxdepth: 1
    :glob:

    frontend/*

@javiereguiluz
Copy link
Member

Thanks Christian ... and thanks Assetic. We no longer need you ... but you were great!

@javiereguiluz javiereguiluz merged commit 3f5eda1 into symfony:4.0 Jul 11, 2018
javiereguiluz added a commit that referenced this pull request Jul 11, 2018
This PR was merged into the 4.0 branch.

Discussion
----------

remove reference to Assetic

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

3f5eda1 remove reference to Assetic
@xabbuh xabbuh deleted the remove-assetic-references branch July 11, 2018 14:39
@@ -93,6 +86,7 @@ Other Front-End Articles
:hidden:
:glob:

frontend/assetic
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this does not help. I also forgot to remove one paragraph. Both issues should be fixed with #10059.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants