Replace more occurrences of Controller by AbstractController #10045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added a commit
that referenced
this pull request
Jul 11, 2018
…ller (javiereguiluz) This PR was merged into the 4.1 branch. Discussion ---------- Replace more occurrences of Controller by AbstractController This continues #10030. I also propose to replace some `ControllerTrait::` by `AbstractController::`. Let's not be pedantic about this. The helper methods are technically defined in the trait, but most people use them via the Abstract base controller. People advanced enough to not use `AbstractController` know perfectly how to use this trait. Commits ------- 80c3c29 Replace more occurrences of Controller by AbstractController
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues #10030.
I also propose to replace some
ControllerTrait::byAbstractController::. Let's not be pedantic about this. The helper methods are technically defined in the trait, but most people use them via the Abstract base controller. People advanced enough to not useAbstractControllerknow perfectly how to use this trait.