Doctrine server_version should always be a string #10082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
changed the title
|
@alexander-schranz thanks for fixing this bug. It's truly embarrassing to not follow the best practices explained just a few lines above 😅 Congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Jul 18, 2018
…nder-schranz) This PR was merged into the 2.8 branch. Discussion ---------- Doctrine server_version should always be a string As the comment above say the server_version should always be a string and wrapped by quotes. Commits ------- 1bb4d26 server_version should always be a string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the comment above say the server_version should always be a string and wrapped by quotes.