-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Routing] Update routing.rst, add example routes as annotations #10201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @andreybolonin! Thanks for the PR to add more details :). I just updated a few parts of the code to use Could you update the code to not use this class? It's actually a bit odd, I see why you used Status: Needs work |
@weaverryan I think it's really difficult to not use |
Another solution would be to not use |
Andrey, we're sorry for not having merged this until today. We finally did. We decided to keep the example with the AnnotatedRouteControllerLoader because the docs about Symfony components are read by advanced developers and they'll know what to do (install the dependency or copy code from it). Thanks! |
…tations (andreybolonin, weaverryan) This PR was submitted for the 4.1 branch but it was merged into the 4.3 branch instead (closes #10201). Discussion ---------- [Routing] Update routing.rst, add example routes as annotations <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 54743d6 cleaning up some use statements, etc 0a1badf Update routing.rst
@javiereguiluz thx |
No description provided.