Adding check for environments #10239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Sep 3, 2018
| @@ -37,13 +40,13 @@ create an alias pointing to the existing ``profiler`` service: | |||
|
|
|||
| .. code-block:: yaml | |||
|
|
|||
| # config/services.yaml | |||
| # config/dev/services.yaml | |||
There was a problem hiding this comment.
Shouldn't this be config/services_dev.yaml instead?
javiereguiluz
added a commit
that referenced
this pull request
Sep 5, 2018
This PR was merged into the 4.1 branch. Discussion ---------- Adding check for environments Wasn't sure the best way to change these, but basically, the `@profiler` service (as I understand it) won't exist unless in `dev` or `test` by default. The example should allow for `null` to be passed for the profiler, and do nothing if it is null. Commits ------- 8f91078 Adding check for environments
|
@aequasi thanks for improving this article to show the entire code needed to make it work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't sure the best way to change these, but basically, the
@profilerservice (as I understand it) won't exist unless indevortestby default. The example should allow fornullto be passed for the profiler, and do nothing if it is null.