Skip to content

Minor improvements #10393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Minor improvements #10393

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26c3f85
Minor improvements
ThomasLandauer Sep 24, 2018
4ecd614
Capitalizing headings
ThomasLandauer Sep 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions frontend/encore/faq.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ FAQ and Common Issues

.. _how-do-i-deploy-my-encore-assets:

How do I deploy my Encore Assets?
How Do I Deploy My Encore Assets?
---------------------------------

There are two important things to remember when deploying your assets.

**1) Compile assets for production**
**1) Compile Assets for Production**

Optimize your assets for production by running:

Expand All @@ -19,11 +19,12 @@ Optimize your assets for production by running:
That will minify your assets and make other performance optimizations. Yay!

But, what server should you run this command on? That depends on how you deploy.
For example, you could execute this locally (or on a build server), and use rsync
or something else to transfer the built files to your server. Or, you could put your
files on your production server first (e.g. via a git pull) and then run this command
on production (ideally, before traffic hits your code). In this case, you'll need
to install Node.js on your production server.
For example, you could execute this locally (or on a build server), and use
[rsync](https://rsync.samba.org/) or something else to transfer the built files
to your production server. Or, you could put your files on your production server
first (e.g. via ``git pull``) and then run this command on production
(ideally, before traffic hits your code). In this case, you'll need to install
Node.js on your production server.

**2) Only Deploy the Built Assets**

Expand All @@ -34,13 +35,13 @@ asset files, **unless** you plan on running ``encore production`` on your produc
machine. Once your assets are built, these are the *only* thing that need to live
on the production server.

Do I need to Install Node.js on my Production Server?
Do I Need to Install Node.js on My Production Server?
-----------------------------------------------------

No, unless you plan to build your production assets on your production server,
which is not recommended. See `How do I deploy my Encore Assets?`_.
which is not recommended. See `How Do I Deploy my Encore Assets?`_.

What Files Should I commit to git? And which should I Ignore?
What Files Should I Commit to git? And which Should I Ignore?
-------------------------------------------------------------

You should commit all of your files to git, except for the ``node_modules/`` directory
Expand Down