Replace extra ... #10475
Merged
Replace extra ... #10475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suppose this `...` should be replaced with simple comma. Also should be fixed in 3.3 documentation, but this branch is not allowed to be edited.
OskarStark
reviewed
Oct 12, 2018
| @@ -19,7 +19,7 @@ An Autowiring Example | |||
| --------------------- | |||
|
|
|||
| Imagine you're building an API to publish statuses on a Twitter feed, obfuscated | |||
| with `ROT13`_... a fun encoder that shifts all characters 13 letters forward in | |||
| with `ROT13`_, a fun encoder that shifts all characters 13 letters forward in | |||
There was a problem hiding this comment.
not sure if we need the fun in the sentence
There was a problem hiding this comment.
It's not strictly needed ... but let's keep it :)
|
Thanks @u-mulder. |
javiereguiluz
added a commit
that referenced
this pull request
Oct 12, 2018
This PR was merged into the 3.4 branch. Discussion ---------- Replace extra ... I suppose this `...` should be replaced with simple comma. Also should be fixed in 3.3 documentation, but this branch is not allowed to be edited. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 1d1f8ec Replace extra ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suppose this
...should be replaced with simple comma. Also should be fixed in 3.3 documentation, but this branch is not allowed to be edited.