Documentation: copy-files.rst: fix missing code-block #10672
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Nov 14, 2018
frontend/encore/copy-files.rst
Outdated
| @@ -54,6 +54,8 @@ include a hash based on their content. | |||
|
|
|||
| To render inside Twig, use the ``asset()`` function: | |||
|
|
|||
| .. code-block:: twig | |||
There was a problem hiding this comment.
Should this be .. code-block:: html+twig instead?
There was a problem hiding this comment.
Maybe it should indeed, I'm not used to rst format :-)
Should I make the change?
There was a problem hiding this comment.
looking at our other code blocks I'd say yes please :)
There was a problem hiding this comment.
Done, thanks for the insight!
xabbuh
approved these changes
Nov 14, 2018
|
Thanks Quentin. |
javiereguiluz
added a commit
that referenced
this pull request
Nov 14, 2018
…hteuchteu) This PR was submitted for the 4.1 branch but it was squashed and merged into the 3.4 branch instead (closes #10672). Discussion ---------- Documentation: copy-files.rst: fix missing code-block The latest code block in [Copying & Referencing Images](https://symfony.com/doc/current/frontend/encore/copy-files.html) is missing a `code-block` Commits ------- a98e0d8 Documentation: copy-files.rst: fix missing code-block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest code block in Copying & Referencing Images is missing a
code-block