Skip to content

Framework configuration > Cache pools > Fix FQCN #10708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Framework configuration > Cache pools > Fix FQCN #10708

wants to merge 1 commit into from
+1 −1

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Nov 27, 2018

Namespace was escaped so this fixes it.

ghost
ghost approved these changes Nov 27, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

kunicmarko20
kunicmarko20 approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@kunicmarko20 kunicmarko20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid fix, but this bug is also on 3.4, I think this PR should target that branch, not sure tho. Let's wait for docs team

@javiereguiluz javiereguiluz added this to the 3.4 milestone Nov 28, 2018
@javiereguiluz
Copy link
Member

Thanks @ruudk! Merged in 3.4.

javiereguiluz added a commit that referenced this pull request Nov 28, 2018
@javiereguiluz
minor #10708 Framework configuration > Cache pools > Fix FQCN (ruudk)
0bd99e9 
This PR was submitted for the 4.1 branch but it was merged into the 3.4 branch instead (closes #10708).

Discussion
----------

Framework configuration > Cache pools > Fix FQCN

Namespace was escaped so this fixes it.

Commits
-------

4beae61 Framework configuration > Cache pools > Fix FQCN
@ruudk ruudk deleted the patch-2 branch November 28, 2018 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhelias maxhelias maxhelias approved these changes

@kunicmarko20 kunicmarko20 kunicmarko20 approved these changes

Assignees
No one assigned
Labels
FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@ruudk @javiereguiluz @maxhelias @kunicmarko20 @carsonbot