Skip to content

Fix example for collection form type #10717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix example for collection form type #10717

wants to merge 2 commits into from

Conversation

kunicmarko20
Copy link
Contributor

If I am correct

 | list.children().length;

does the same thing as the line I removed.

ghost
ghost approved these changes Nov 29, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. Thank you.

@xabbuh
Copy link
Member

xabbuh commented Nov 30, 2018

Thank you @kunicmarko20.

xabbuh added a commit that referenced this pull request Nov 30, 2018
@xabbuh
minor #10717 Fix example for collection form type (kunicmarko20)
db4f44d 
This PR was squashed before being merged into the 3.4 branch (closes #10717).

Discussion
----------

Fix example for collection form type

If I am correct

```
 | list.children().length;
```

does the same thing as the line I removed.

Commits
-------

2f1cc8d Fix example for collection form type
@xabbuh xabbuh closed this Nov 30, 2018
@kunicmarko20 kunicmarko20 deleted the fix_example branch November 30, 2018 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kunicmarko20 @xabbuh @carsonbot