Skip to content

[Validator] Range constraint: min and mix can be integer or string #10807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

wuestkamp
Copy link
Contributor

When using this with DateTime the min and max can be strings.

@wuestkamp wuestkamp changed the title min and mix can be integer or string Range constraint: min and mix can be integer or string Dec 23, 2018
@javiereguiluz javiereguiluz added this to the 3.4 milestone Dec 26, 2018
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for proposing this change! But I would suggest to be even more explicit.

@wuestkamp
Copy link
Contributor Author

updated.

Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@HeahDude HeahDude changed the title Range constraint: min and mix can be integer or string [Validator] Range constraint: min and mix can be integer or string Jan 1, 2019
@xabbuh
Copy link
Member

xabbuh commented Jan 1, 2019

Thanks and a happy new year @wuestkamp!

xabbuh added a commit that referenced this pull request Jan 1, 2019
… or string (wuestkamp)

This PR was squashed before being merged into the 3.4 branch (closes #10807).

Discussion
----------

[Validator] Range constraint: min and mix can be integer or string

When using this with `DateTime` the min and max can be strings.

Commits
-------

560a96f [Validator] Range constraint: min and mix can be integer or string
@xabbuh xabbuh closed this Jan 1, 2019
nikophil pushed a commit to nikophil/symfony-docs that referenced this pull request Jan 3, 2019
…integer or string (wuestkamp)

This PR was squashed before being merged into the 3.4 branch (closes symfony#10807).

Discussion
----------

[Validator] Range constraint: min and mix can be integer or string

When using this with `DateTime` the min and max can be strings.

Commits
-------

560a96f [Validator] Range constraint: min and mix can be integer or string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants