Skip to content

added blank line after .. versionadded:: directive #10823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

OskarStark
Copy link
Contributor

No description provided.

Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn’t always true, but it looks like it renders for with the line break now. So this is for consistency

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered about this some time ago, but it seems that the versionadded directive now behaves the same as other directives in more recent Sphinx versions.

@OskarStark
Copy link
Contributor Author

I wondered about this some time ago, but it seems that the versionadded directive now behaves the same as other directives in more recent Sphinx versions.

yes, I talked to Ryan before and we double checked if they get rendered correctly, and thats the case...

@xabbuh
Copy link
Member

xabbuh commented Jan 1, 2019

Thank you Oskar and a happy new year! 🎉

@xabbuh xabbuh merged commit ec17bff into symfony:3.4 Jan 1, 2019
xabbuh added a commit that referenced this pull request Jan 1, 2019
…rStark)

This PR was merged into the 3.4 branch.

Discussion
----------

added blank line after .. versionadded:: directive

Commits
-------

ec17bff added blank line after .. versionadded:: directive
@OskarStark
Copy link
Contributor Author

For you guys too 🎊🥳

@OskarStark OskarStark deleted the line-break-after-versionadded-directive branch January 1, 2019 14:37
nikophil pushed a commit to nikophil/symfony-docs that referenced this pull request Jan 3, 2019
…e (OskarStark)

This PR was merged into the 3.4 branch.

Discussion
----------

added blank line after .. versionadded:: directive

Commits
-------

ec17bff added blank line after .. versionadded:: directive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants