Skip to content

Update Range.rst #10918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Update Range.rst #10918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions reference/constraints/Range.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,15 +320,15 @@ Options
min
~~~

**type**: ``int`` or ``string`` (date format)
**type**: ``numeric`` or ``string`` (date format)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should call it number IMHO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was doubtful indeed. Is true that number is better but numeric gives the reader back additional infos somehow. Don't know if number (same for numeric of course) is used elsewhere in docs. Whe should try adopt that standard (if any)


This required option is the "min" value. Validation will fail if the given
value is **less** than this min value.

max
~~~

**type**: ``int`` or ``string`` (date format)
**type**: ``numeric`` or ``string`` (date format)

This required option is the "max" value. Validation will fail if the given
value is **greater** than this max value.
Expand Down