Skip to content

Use the ".. deprecated::" directive for deprecations #11178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Mar 17, 2019

Refs #11154

Todo:

@wouterj wouterj added Waiting Code Merge Docs for features pending to be merged On hold and removed Waiting Code Merge Docs for features pending to be merged labels Mar 17, 2019
@wouterj
Copy link
Member

wouterj commented Mar 17, 2019

Approved! And added "on hold", as we first have to make sure @javiereguiluz adds nice styling for this on symfony.com. The deprecated directive is rendered the same way as the versionadded (including the .versionmodified class), except that it's main class is deprecated. So it should be fairly easy to reuse the versionadded styles and only modify the color (i.e. some blackish)

@javiereguiluz
Copy link
Member

There is a pending PR on symfony.com private repo to add the styles:

Before

before

After

after

And in dark mode:

after-dark-theme

@wouterj
Copy link
Member

wouterj commented Mar 18, 2019

Nice!

@OskarStark
Copy link
Contributor Author

Wow this looks amazing 🥰👍🏻

@OskarStark OskarStark force-pushed the use-new-deprecated-directive branch from 2b0504d to 7e53442 Compare March 18, 2019 12:37
@javiereguiluz
Copy link
Member

The style changes were merged on symfony.com, so we can now merge this. Thanks Oskar!

@OskarStark OskarStark deleted the use-new-deprecated-directive branch March 20, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants