Skip to content

Correct many-to-many to many-to-one #11210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2,625 commits into from
Closed

Correct many-to-many to many-to-one #11210

wants to merge 2,625 commits into from

Conversation

exastion
Copy link

No description provided.

javiereguiluz and others added 30 commits January 22, 2019 09:00
This PR was merged into the 4.2 branch.

Discussion
----------

Updated the output of debug:autowiring

Fixes #10603 and fixes #9247.

Commits
-------

6dcf691 Updated the output of debug:autowiring
This PR was merged into the master branch.

Discussion
----------

Documented the new csrf_token field prefix

Fixes #10884.

Commits
-------

ea1dea0 Documented the new csrf_token field prefix
…ereguiluz)

This PR was merged into the master branch.

Discussion
----------

Documented the default values of text() and html()

Documents symfony/symfony#28581

See also https://symfony.com/blog/new-in-symfony-4-3-domcrawler-improvements

Commits
-------

851956d Documented the default values of text() and html()
* 3.4:
  Clarify a sentence
  Update serializer.rst
  Fix typos and improve wording for the Lock component documentation
* 4.1:
  Minor reword in the testing article
  Clarify a sentence
  Update serializer.rst
  Fix typos and improve wording for the Lock component documentation
  More precision about the log directory permissions
  Added some missing steps in the main form login article
* 4.2:
  Document the multi-host DSN for Memcache caches
  Minor reword in the testing article
  Mentioned all the debug:* commands
  Clarify a sentence
  Update serializer.rst
  Fix typos and improve wording for the Lock component documentation
  More precision about the log directory permissions
  Updated the output of debug:autowiring
  Minor tweak for translation:update command
  Added some missing steps in the main form login article
This PR was merged into the 4.2 branch.

Discussion
----------

[#10914] fix a minor typo

Commits
-------

6811b4d [#10914] fix a minor typo
* 3.4:
  Add Diversity Documentation
* 4.1:
  Add Diversity Documentation
* 4.2:
  [#10914] fix a minor typo
  Add Diversity Documentation
This PR was squashed before being merged into the master branch (closes #10835).

Discussion
----------

[Form] Documenting the block_prefix option

Documenting new feature: symfony/symfony#29680

Commits
-------

d9382d4 [Form] Documenting the block_prefix option
This PR was merged into the 4.1 branch.

Discussion
----------

form_help description added

Commits
-------

610a7a8 form_help description added
… (romaricdrigon)

This PR was submitted for the 4.2 branch but it was merged into the 4.1 branch instead (closes #10925).

Discussion
----------

MakerBundle v1.11.13 uses urlGenerator instead of Router

Hello,

Since version 1.11.3 and PR [#349](symfony/maker-bundle#349) MakerBundle uses `UrlGeneratorInterface` instead of `RouterInterface` when generating a new Guard for a login form, and the corresponding property changed. Hence the documentation code snippet is misleading.

I'm not totally sure of which branch to PR on; being a change from latest version of MakerBundle, I think this is especially important for new projects, so using the latest Symfony version.

Commits
-------

f00344a MakerBundle uses urlGenerator instead of Router
This PR was squashed before being merged into the 4.1 branch (closes #10926).

Discussion
----------

Simplified the form theming docs

This is a total revamp of all the docs related to form themes and form customization. The current problems are:

* `form/form_customization.rst` and `form/rendering.rst` are too similar.
* `form/form_themes.rst` is incomplete and confusing
* Most of the form theming things are explained in `form/form_customization.rst`
  instead of `form/form_themes.rst`
* `reference/forms/twig_reference.rst` and `reference/twig_reference.rst`
  duplicate lots of contents

This PR does the following:

* Delete `form/rendering.rst` and merge it with `form/form_customization.rst`
* Remove anything related to form themes from `form/form_customization.rst`
* Add everything related to form themes to ``form/form_themes.rst``
* Remove the duplicated contents from `reference/twig_reference.rst` and link
  to the other form reference.

The result is:

* `form.rst`: main article explaining all the basics about forms.
* `form/form_customization.rst` explains everything about Form helper functions
  (`form_start()`, `form_row()`, etc.) and form variables (`required`, `compound`, etc.)
* `form/form_themes.rst` explains everything about form themes, including the
  form fragment naming and all the different options to create themes.

On top of all the above, this PR removes 800 lines of docs!

Commits
-------

7cdf54a Simplified the form theming docs
* 3.4:
  Update filesystem.rst
  Update form_dependencies.rst
  Fix encore advanced config watchOptions example
  [WebLink] Add an example using Priority Hints
  Update form.rst
  Use "number" instead of "numeric"
  Update Range.rst
* 4.1:
  Simplified the form theming docs
  MakerBundle uses urlGenerator instead of Router
  Update filesystem.rst
  Update form_dependencies.rst
  Fix encore advanced config watchOptions example
  [WebLink] Add an example using Priority Hints
  form_help description added
  Update form.rst
  Use "number" instead of "numeric"
  Update Range.rst
* 4.2:
  Simplified the form theming docs
  MakerBundle uses urlGenerator instead of Router
  Update filesystem.rst
  Update form_dependencies.rst
  Fix encore advanced config watchOptions example
  [WebLink] Add an example using Priority Hints
  form_help description added
  Update form.rst
  Use "number" instead of "numeric"
  Update Range.rst
…e, xabbuh)

This PR was merged into the 4.1 branch.

Discussion
----------

[DependencyInjection] fix a config filename

finishes #10870

Commits
-------

5dc3c4d update remaining file references
fbf1daa Update 3.3-di-changes.rst
* 3.4:
  Update data_transformers.rst
  Fixed the \"learn more\" section of Testing article
  Change gender to eye-color
* 4.1:
  Update data_transformers.rst
  Fixed the \"learn more\" section of Testing article
  update remaining file references
  Update 3.3-di-changes.rst
  Change gender to eye-color
javiereguiluz and others added 26 commits March 18, 2019 09:58
* 3.4:
  Update entity.rst
* 3.4:
  Update advanced-config.rst
* 3.4:
  Fixing error at Class Constraint Validator
…oel)

This PR was merged into the 4.2 branch.

Discussion
----------

Fix typo in http_kernel_controller_resolver.rst

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

2a8b2fe Fix typo in http_kernel_controller_resolver.rst
* 3.4:
  [Encore] Fixed typo
  fix indention
* 3.4:
  Use the \".. deprecated::\" directive for deprecations
  use same order for all configuration-blocks
  Add precision on the concerned fields
  Correct a sentence meaning
  use :: instead of .. code-block:: php
This PR was merged into the 4.2 branch.

Discussion
----------

use correct order of code-blocks

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

8c09d02 use correct order of code-blocks
This PR was squashed before being merged into the 4.2 branch (closes #11195).

Discussion
----------

Consistency changes

This PR brings more consistency to the 4.2 branch and should be reviewed commit by commit.

Commits
-------

1673298 Consistency changes
This PR was merged into the 4.2 branch.

Discussion
----------

use "behavior" instead of "behaviour"

We use **behavior** many more then **behaviour** throughout the documentation.

Commits
-------

27b7621 typo
This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes #11098).

Discussion
----------

Some cache files might be written in runtime

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

3fcb22c Some cache files might be written in runtime
* 3.4:
  use consistent placeholder comments in yaml, php and xml
* 3.4:
  Revamped the main security reference article
This PR was merged into the 4.2 branch.

Discussion
----------

Fixed some references

Commits
-------

3f646a2 Fixed some references
* 3.4:
  [#11139] fix a minor typo
This PR was merged into the 4.2 branch.

Discussion
----------

add missing brackets

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

7be1bcb add missing brackets
* 3.4:
  Add missing security guard sub-component
  [#8416] some minor tweaks
  Update unit_testing.rst
  removed blank line and space
  use "behavior" instead of "behaviour"
  Remove unnecessary backslash escape
  Improve now what sentence
@javiereguiluz
Copy link
Member

@exastion thanks for your contribution! Sadly, there was a problem when creating the pull request (don't worry, this has happened to all of us in the past!!). I recommend you to close this pull request and create a new one that only contains the change you want to make, which is 7f06029

If you need help creating the pull request, you can ask us in the #contribs channel of the Symfony Slack (https://symfony.com/slack). Thanks!

@exastion
Copy link
Author

Forking from right branch in #11227

@exastion exastion closed this Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.