streamline the constraints reference #11366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot Oskar! This probably took you some time, so we appreciate that! |
javiereguiluz
added a commit
that referenced
this pull request
Apr 9, 2019
This PR was merged into the 3.4 branch. Discussion ---------- streamline the constraints reference I felt the constraints need some love 💟 Commits ------- ce77fdb streamline the constraints reference
xabbuh
reviewed
Jun 17, 2019
| @@ -73,8 +73,6 @@ will contain a Business Identifier Code (BIC). | |||
|
|
|||
| class Transaction | |||
| { | |||
| protected $businessIdentifierCode; | |||
There was a problem hiding this comment.
@OskarStark Wouldn't it be less confusing to always add the property instead?
There was a problem hiding this comment.
Ofc we can, but most of them does not have them.
You get my 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I felt the constraints need some love 💟