Skip to content

Little layout problem #11379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2019
Merged

Little layout problem #11379

merged 1 commit into from
Apr 9, 2019

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented Apr 9, 2019

It seems to me a layout mistake, isn't it ?

@javiereguiluz
Copy link
Member

@l-vo there's a problem with the pull request. Also, 4.1 branch is no longer maintained, so pull requests can only be created against 3.4, or 4.2 or master. Thanks!

@l-vo l-vo changed the base branch from 4.1 to 4.2 April 9, 2019 11:13
@l-vo
Copy link
Contributor Author

l-vo commented Apr 9, 2019

@javiereguiluz thank you, I thought that the PR should target the branch where the error was introduced, if the branch is still visible in the online docs version selector.

So I changed target branch to 4.2 :)

wouterj
wouterj approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now!

@javiereguiluz javiereguiluz added this to the 4.2 milestone Apr 9, 2019
@javiereguiluz
Copy link
Member

@l-vo your reasoning was almost correct: bug fixes should go to the oldest, but still maintained, branch that contains the bug.

This is sometimes tricky, and that's why we list maintained versions here: https://symfony.com/roadmap

In any case, your PR is now perfect and we thank you for that!

@javiereguiluz javiereguiluz merged commit 70f654c into symfony:4.2 Apr 9, 2019
javiereguiluz added a commit that referenced this pull request Apr 9, 2019
@javiereguiluz
minor #11379 Little layout problem (l-vo)
d912b43 
This PR was merged into the 4.2 branch.

Discussion
----------

Little layout problem

It seems to me a layout mistake, isn't it ?

Commits
-------

70f654c Fix little layout problem
@l-vo
Copy link
Contributor Author

l-vo commented Apr 9, 2019 •
edited
Loading

@javiereguiluz it makes sense, thanks for the information. For the PR... you're welcome :)

@l-vo l-vo deleted the patch-2 branch April 9, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@l-vo @javiereguiluz @wouterj @carsonbot