Added pitfall hint about Lock::isAcquired() #11426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
reviewed
Apr 15, 2019
|
Ping @jderusse, I'm actually happy with the wording now, what do you think? |
OskarStark
reviewed
May 2, 2019
OskarStark
approved these changes
May 2, 2019
OskarStark
reviewed
May 3, 2019
jderusse
approved these changes
May 7, 2019
OskarStark
approved these changes
May 24, 2019
OskarStark
requested review from
javiereguiluz
and removed request for
javiereguiluz
OskarStark
requested review from
wouterj and
weaverryan
and removed request for
wouterj
xabbuh
reviewed
Jun 8, 2019
OskarStark
approved these changes
Jun 11, 2019
|
@Toflar could you please squash your commits into one? Unfortunately, because of different authors, we cannot do that for you 🙏 Thanks! |
|
Sure, rebased :) |
|
Thank you Yanick. |
OskarStark
added a commit
that referenced
this pull request
Jun 11, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Added pitfall hint about Lock::isAcquired() I've hit that issue on Friday so I figured I'd just add a hint so other devs don't make the same mistake 😄 /cc @jderusse (and thanks for the help!) Commits ------- 6660f2d Documented Lock::isAcquired() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've hit that issue on Friday so I figured I'd just add a hint so other devs don't make the same mistake 😄
/cc @jderusse (and thanks for the help!)