[Ldap] minor: better query string docs #11454
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsmith77
reviewed
Apr 18, 2019
Simperfit
force-pushed
the
minor/better-docs-on-ldap-query-string
branch
from
cd47ea4 to
c300ab7
Compare
Simperfit
force-pushed
the
minor/better-docs-on-ldap-query-string
branch
from
c300ab7 to
bdc2816
Compare
|
another review ? |
javiereguiluz
added a commit
that referenced
this pull request
Apr 25, 2019
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #11454). Discussion ---------- [Ldap] minor: better query string docs <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> see symfony/symfony#26316 (comment) Commits ------- 0dfb46f [Ldap] minor: better query string docs
|
Thanks for improving the wording of this option. Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see symfony/symfony#26316 (comment)