Fixing retrieving metadata examples #11473
Conversation
There was no example about retrieving place metadata from the controller. I tried to fixed it as well as the example of retrieving transition metadata. Don't know wether the code I propose is correct. It would need a revision from anybody who knows how it works.
The array key comes from configuration in line 528
|
@carherco can you check if your Pr is still relevant on 4.3 doc now ? |
|
@noniagriconomie MetadataStoreInterface (https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Workflow/Metadata/MetadataStoreInterface.php) has not changed in 4.3 so this docs should be the same as in 4.2 version. |
default value of priority and max_num_of_words are now numbers
|
hello @carherco , i meant rebase the PR and see if your addition is still relevant as it is or if it needs rewrite :) |
|
Sorry, I don't manage well rebase, merge, pull request... I merged branch 'master' into patch-1, repair conflicts and rewrite some docs. Then I realised that you asked me to do it not with 'master' but with branch 4.3. I don't know how, but I did a pull request: #11591 I don't know if i am doing things well or not. I hope you are able to manage with the mess I created. Sorry. |
|
@carherco thanks for this contribution and we're really sorry it took us so long to merge it. We're trying to merge in the 4.3 branch but we're facing too many issues. Could you please rebase this to the 4.3 branch? If you can't ... we'll create a new pull request for 4.3 with your changes (or, if you want, you can create a new pull request against 4.3 with these changes so you get credit for the contribution). Thanks! |
|
Closed in favor of #12360. Thanks! |
There was no example about retrieving place metadata from the controller. I tried to fixed it as well as the example of retrieving transition metadata. Don't know wether the code I propose is correct. It would need a revision from anybody who knows how it works.