-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix code example for property info #11498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think there's been a mistake here. "Analyze" is a verb, not a noun. "Analyzes" is the third-person form of the verb or the plural of a misspelling of analysis. In American English it's OK to call it "analysis" (singular) / "analyses" (plural). |
Looking at the original code ... it looks like it's wrong too. It should be:
|
Yes, I think the same, I need to dive into this topic twice today to find the right approach, but I think you are right 👍 Shall I fix it in this PR? |
I think the property needs to be plural, , the adder/remover needs to be singular, the argument needs to be singular, right? |
d034997
to
2dda40d
Compare
2dda40d
to
e9454aa
Compare
I wonder if we still need the |
e9454aa
to
c146962
Compare
I removed it |
Thanks Oskar. |
This PR was merged into the 3.4 branch. Discussion ---------- fix code example for property info <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- c146962 fix code example for property info
No description provided.