Skip to content

fix code example for property info #11498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

OskarStark
Copy link
Contributor

No description provided.

@javiereguiluz
Copy link
Member

javiereguiluz commented Apr 29, 2019

I think there's been a mistake here. "Analyze" is a verb, not a noun. "Analyzes" is the third-person form of the verb or the plural of a misspelling of analysis.

In American English it's OK to call it "analysis" (singular) / "analyses" (plural).

@javiereguiluz
Copy link
Member

Looking at the original code ... it looks like it's wrong too. It should be:

  • Property in singular private $analysis
  • Methods in plural: addAnalyses(), removeAnalyses()

@OskarStark
Copy link
Contributor Author

Looking at the original code ... it looks like it's wrong too. It should be:

Yes, I think the same, I need to dive into this topic twice today to find the right approach, but I think you are right 👍

Shall I fix it in this PR?

@OskarStark
Copy link
Contributor Author

OskarStark commented Apr 29, 2019

Property in singular private $analysis

I think the property needs to be plural, , the adder/remover needs to be singular, the argument needs to be singular, right?

@OskarStark OskarStark changed the title use American English in code example fix code example for property info Apr 29, 2019
@javiereguiluz
Copy link
Member

I wonder if we still need the foot / feet example. It looks like the usual "silly" and forced example that you can find in some programming books. We already show an irregular transformation "analyses/analysis", so that may be enough.

@OskarStark
Copy link
Contributor Author

I removed it

@javiereguiluz
Copy link
Member

Thanks Oskar.

@javiereguiluz javiereguiluz merged commit c146962 into symfony:3.4 Apr 30, 2019
javiereguiluz added a commit that referenced this pull request Apr 30, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

fix code example for property info

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

c146962 fix code example for property info
@OskarStark OskarStark deleted the american-english branch April 30, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants