-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Minor phrasing #11529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor phrasing #11529
Conversation
I agree that the original wording is not perfectly clear ... but the new proposed wording isn't much better to me. @OskarStark what do you think about this? Thanks. |
I agree with Shrey and with you, what about: - This article explains how to create and load those bundle services files.
+ This article explains how to create and load service files from the bundle directory structure. |
I really like this @OskarStark. Only minor suggestion from me would be:
How is that? //cc @javiereguiluz |
Yes, I like the new proposals. The latest from @shreypuranik sound better to me, but both are great. Thank you! |
Thanks @javiereguiluz . @OskarStark are you happy for me to amend the PR with this re-phrasing? |
Yes, thank you 👍 |
Thanks @OskarStark @javiereguiluz . I have updated the Pull Request with the re-phrasing. |
Thanks a lot for improving the docs and your fast reactions! It's now merged into 4.2, and I'll take care of merging it into the newer versions from there. |
No description provided.