Skip to content

Minor phrasing #11529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2019
Merged

Minor phrasing #11529

merged 1 commit into from
May 11, 2019

Conversation

shreypuranik
Copy link
Contributor

No description provided.

@javiereguiluz
Copy link
Member

I agree that the original wording is not perfectly clear ... but the new proposed wording isn't much better to me. @OskarStark what do you think about this? Thanks.

@OskarStark
Copy link
Contributor

OskarStark commented May 10, 2019

I agree with Shrey and with you, what about:

- This article explains how to create and load those bundle services files.
+ This article explains how to create and load service files from the bundle directory structure.

@shreypuranik
Copy link
Contributor Author

shreypuranik commented May 10, 2019

I really like this @OskarStark. Only minor suggestion from me would be:

  • From your suggestion: This article explains how to create and load service files from the bundle directory structure.
  • To: This article explains how to create and load service files using the bundle directory structure.

How is that? //cc @javiereguiluz

@javiereguiluz
Copy link
Member

Yes, I like the new proposals. The latest from @shreypuranik sound better to me, but both are great. Thank you!

@shreypuranik
Copy link
Contributor Author

Thanks @javiereguiluz .

@OskarStark are you happy for me to amend the PR with this re-phrasing?

@OskarStark
Copy link
Contributor

@OskarStark are you happy for me to amend the PR with this re-phrasing?

Yes, thank you 👍

@shreypuranik
Copy link
Contributor Author

Thanks @OskarStark @javiereguiluz . I have updated the Pull Request with the re-phrasing.

@wouterj wouterj changed the base branch from master to 4.2 May 11, 2019 18:34
@wouterj
Copy link
Member

wouterj commented May 11, 2019

Thanks a lot for improving the docs and your fast reactions! It's now merged into 4.2, and I'll take care of merging it into the newer versions from there.

@wouterj wouterj merged commit 14432ce into symfony:4.2 May 11, 2019
wouterj added a commit that referenced this pull request May 11, 2019
This PR was submitted for the master branch but it was squashed and merged into the 4.2 branch instead (closes #11529).

Discussion
----------

Minor phrasing

Commits
-------

14432ce Minor phrasing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants