Skip to content

Fix php config example for hinclude_default_template #11543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2019

Conversation

andrew-demb
Copy link
Contributor

In PHP example used the wrong type for parameter - array, instead of a correct string.

Other config examples are not affected.

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@xabbuh xabbuh added this to the 3.4 milestone May 9, 2019
@OskarStark
Copy link
Contributor

Thank you and congrats on your first contribution to the Symfony documentation! 🎉

@OskarStark OskarStark merged commit cccf79c into symfony:master May 9, 2019
OskarStark added a commit that referenced this pull request May 9, 2019
…drew-demb)

This PR was merged into the master branch.

Discussion
----------

Fix php config example for hinclude_default_template

In PHP example used the wrong type for parameter - `array`, instead of a correct `string`.

Other config examples are not affected.

Commits
-------

cccf79c Fix php config example for hinclude_default_template
OskarStark added a commit that referenced this pull request May 9, 2019
…drew-demb)

This PR was merged into the master branch.

Discussion
----------

Fix php config example for hinclude_default_template

In PHP example used the wrong type for parameter - `array`, instead of a correct `string`.

Other config examples are not affected.

Commits
-------

cccf79c Fix php config example for hinclude_default_template
OskarStark added a commit that referenced this pull request May 9, 2019
* 3.4:
  minor #11543 Fix php config example for hinclude_default_template (andrew-demb)
OskarStark added a commit that referenced this pull request May 9, 2019
* 4.2:
  minor #11543 Fix php config example for hinclude_default_template (andrew-demb)
OskarStark added a commit that referenced this pull request May 9, 2019
* 4.3:
  minor #11543 Fix php config example for hinclude_default_template (andrew-demb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants