Skip to content

Fix: make class clickable #11544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2019
Merged

Fix: make class clickable #11544

merged 2 commits into from
May 10, 2019

Conversation

Art4
Copy link
Contributor

@Art4 Art4 commented May 8, 2019

Small fix that makes the Symfony\Component\Serializer\Normalizer\NormalizableInterface class clickable to see the api.

This affects the maintained branches 3.4, 4.2 and master.

@Art4 Art4 changed the title make class clickable Fix: make class clickable May 8, 2019
@javiereguiluz
Copy link
Member

@Art4 thanks for this contribution, but I'm afraid that 2.8 branch is no longer supported. It's supported for security issues ... but that's not considered "active support" anymore. Here you can find the currently maintained versions: https://symfony.com/roadmap So, this PR should be rebased against 3.4. Thanks

@Art4
Copy link
Contributor Author

Art4 commented May 9, 2019

Oh, I see. Will do that.

@Art4 Art4 changed the base branch from 2.8 to 3.4 May 9, 2019 07:09
@Art4
Copy link
Contributor Author

Art4 commented May 9, 2019

I've changed the branch to 3.4

@xabbuh xabbuh added this to the 3.4 milestone May 9, 2019
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks nice now!

@javiereguiluz
Copy link
Member

Thanks Artur.

@javiereguiluz javiereguiluz merged commit 237f45c into symfony:3.4 May 10, 2019
javiereguiluz added a commit that referenced this pull request May 10, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

Fix: make class clickable

Small fix that makes the `Symfony\Component\Serializer\Normalizer\NormalizableInterface` class clickable to see the api.

This affects the maintained branches 3.4, 4.2 and master.

Commits
-------

237f45c make class clickable
c9c8f0a Fixing build
@Art4 Art4 deleted the patch-1 branch May 13, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants