Skip to content

Fix: default excluded directories for services #11572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2019
Merged

Fix: default excluded directories for services #11572

merged 1 commit into from
May 14, 2019

Conversation

nicoweb
Copy link
Contributor

@nicoweb nicoweb commented May 14, 2019

No description provided.

@xabbuh xabbuh added this to the 4.2 milestone May 14, 2019
@xabbuh
Copy link
Member

xabbuh commented May 14, 2019

@nicoweb This looks good. 👍 But could you also update the XML and PHP config examples?

@javiereguiluz
Copy link
Member

This is correct according to the latest recipe: https://github.com/symfony/recipes/blob/3b19bd94886555df1997b441b6cf6a1fab088f3a/symfony/framework-bundle/4.2/config/services.yaml#L18

Thanks @nicoweb.

@OskarStark
Copy link
Contributor

Please note, that Kernel.php is also missing in the XML and PHP definitions 😃

@OskarStark
Copy link
Contributor

Thank you Nicolas.

@OskarStark OskarStark merged commit 758008b into symfony:4.2 May 14, 2019
OskarStark added a commit that referenced this pull request May 14, 2019
@OskarStark
minor #11572 Fix: default excluded directories for services (nicoweb)
3941776 
This PR was merged into the 4.2 branch.

Discussion
----------

Fix: default excluded directories for services

Commits
-------

758008b Fix: default excluded directory for services
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@nicoweb @xabbuh @javiereguiluz @OskarStark @carsonbot