fix encore multiple configuration build paths #11593
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added
bug
front-end
Status: Reviewed
and removed
Status: Needs Review
labels
|
@gseidel thanks a lot for fixing this bug and for explaining all perfectly! Also, congrats on your first Symfony Docs contribution 🎉 Note: we merged this in 3.4 branch (the oldest maintained branch that contains the bug) and we'll merge in the other branches automatically; that's why GitHub shows this as "closed" instead of "merged", but it's merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix two things:
%kernel.public_dir%does not exists and%kernel.project_dir%/publicis the correct path.entrypoint.js. The solution is to use two build directories, but this needs two different paths in thewebpack.config.js.Now someone can just copy&paste the code lines and it should work.