Skip to content

[Routing] Fix options utf8 #11691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

maxhelias
Copy link
Contributor

By the way, a configuration-block in the versionadded causes an edge effect.
I don't know how we can fix it.
Example : https://symfony.com/doc/4.3/components/routing.html#unicode-routing-support

@OskarStark
Copy link
Contributor

OskarStark commented Jun 7, 2019

By the way, a configuration-block in the versionadded causes an edge effect.

Please add it below the configuration-block as it belongs to all configuration formats, not just one.

EDIT: Hmm, no I think it will not change anything.
@javiereguiluz ca you please have a look here? Thank you!

@OskarStark OskarStark requested a review from javiereguiluz June 7, 2019 06:47
@OskarStark OskarStark added this to the 4.3 milestone Jun 7, 2019
@maxhelias
Copy link
Contributor Author

@OskarStark, also this versionadded block is not present on master branch, it's weird

@javiereguiluz
Copy link
Member

As we discussed in Symfony Slack ... this is not going to be easy to fix (or even possible). Instead of fixing the code error, in #11696 I propose to simplify this. Let's only mention the annotations case, which is what most people use.

@wouterj
Copy link
Member

wouterj commented Jun 7, 2019

We always try to only use small versionadded/deprecated. It should be removable without missing any documentation. This is why most only say "Feature X was introduced in Symfony Y" or "Feature X was deprecated in favor of Z in Symfony Y". So I would just remove the complete configuration block from the directive, if people use a previous version they should visit a previous version of the docs imo

@maxhelias
Copy link
Contributor Author

I agree with you, I'm closing in favor #11696

@maxhelias maxhelias closed this Jun 7, 2019
@maxhelias maxhelias deleted the fix-routing-utf8 branch June 7, 2019 09:12
javiereguiluz added a commit that referenced this pull request Jun 10, 2019
This PR was merged into the 4.3 branch.

Discussion
----------

[Routing] Simplified some doc

This is an alternative to #11691.

Commits
-------

121897c [Routing] Simplified some doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants