-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Form] Documented the setInvalidMessage() method for data transformers #11756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So 👍 for documenting this feature, but please add it to the DataTransformer article to not advocate wrong usage |
Wouter, thanks for the review ... I've reverted the changes to explain this in the data transformers article. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll merge later today, I want to do a minor reword while merging :)
@javiereguiluz Could you reword the commit message to talk about data transformers instead of data mappers? Might be less confusing for some future reader of the git history. :) |
Ah, maybe that's not necessary. I edited the PR title and during merge we will squash anyway (which should take the PR title as the commit message if I am not mistaken) |
…ata transformers (javiereguiluz) This PR was squashed before being merged into the 4.3 branch (closes #11756). Discussion ---------- [Form] Documented the setInvalidMessage() method for data transformers This fixes #11559. Commits ------- 5c20204 [Form] Documented the setInvalidMessage() method for data transformers
Thank you @javiereguiluz! I've added a bit more info on transformer errors in e33b5b2 and also used a slightly different reason to use exceptions: to show specific errors and include user information, instead of showing a static error. |
* 4.3: Add weeks in the options 'labels' [symfony#11756] Added a bit more info on transformation errors [Form] Documented the setInvalidMessage() method for data transformers
* 4.4: Add weeks in the options 'labels' [symfony#11756] Added a bit more info on transformation errors [Form] Documented the setInvalidMessage() method for data transformers
This fixes #11559.