Update Collection.rst #11760
Merged
Update Collection.rst #11760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Jun 16, 2019
The line:
"personal_email: Email"
contains a mistake, as every constraint name should start on a new line and with the - symbol.
If I use the code sample in the yaml file, it would throw an exception:
"The value Email is not an instance of Constraint in constraint Symfony\Component\Validator\Constraints\Required"
|
@murtukov nice catch! Thanks for fixing this ... and congrats on your first Symfony Docs contribution! Note: we merged this in 3.4 and then, in the other branches automatically. |
javiereguiluz
added a commit
that referenced
this pull request
Jun 17, 2019
This PR was submitted for the 4.3 branch but it was merged into the 3.4 branch instead (closes #11760). Discussion ---------- Update Collection.rst The line: **`personal_email: Email`** contains a mistake, as every constraint name should start on a new line and with the - symbol. If I use the code sample in the yaml file, it would throw an exception: `The value Email is not an instance of Constraint in constraint Symfony\Component\Validator\Constraints\Required"` <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 1440ca3 Update Collection.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line:
personal_email: Emailcontains a mistake, as every constraint name should start on a new line and with the - symbol.
If I use the code sample in the yaml file, it would throw an exception:
The value Email is not an instance of Constraint in constraint Symfony\Component\Validator\Constraints\Required"