Add weeks in the options 'labels' #11804
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SulivanDotEu good catch! Thanks and congrats on your first Symfony Docs contribution! You did it great, but we changed the branch while merging (to merge it in 3.4, the oldest maintained branch that contains the bug). We merged in all the other branchas automatically. Note: GitHub shows this as "closed" instead of "merged" because we changed the branch, but it's merged. |
javiereguiluz
added a commit
that referenced
this pull request
Jun 21, 2019
This PR was submitted for the 4.3 branch but it was merged into the 3.4 branch instead (closes #11804). Discussion ---------- Add weeks in the options 'labels' <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Hi there, In the documentation about [DateIntervalType](https://symfony.com/doc/current/reference/forms/types/dateinterval.html#labels), weeks is missing from the code example. I added it to avoid any confusion. It is my first contribution, not very familiar with all the tools. Commits ------- 828ff37 Add weeks in the options 'labels'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
In the documentation about DateIntervalType, weeks is missing from the code example. I added it to avoid any confusion.
It is my first contribution, not very familiar with all the tools.