Fixed subscribe JWT claim parameter #11888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @dunglas. Thanks! |
dunglas
approved these changes
Jul 4, 2019
|
@dekamaru good catch! The example is faulty, thanks for fixing it (and thanks @javiereguiluz for the mention). |
If you follow this guide and set claim mercure `subscribe` with single string - you get following error from mercure: `json: cannot unmarshal string into Go struct field mercureClaim.subscribe of type []string` Subscribe parameter is array, not single string. You can verfiy this in official example: https://github.com/dunglas/mercure/blob/master/examples/publisher-php.php Just decode `DEMO_JWT` and see content
|
@dekamaru good catch! Thanks for fixing it and congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Jul 5, 2019
This PR was submitted for the 4.3 branch but it was merged into the 4.2 branch instead (closes #11888). Discussion ---------- Fixed subscribe JWT claim parameter If you follow current guide and set claim mercure `subscribe` with single string - you get following error from mercure: `json: cannot unmarshal string into Go struct field mercureClaim.subscribe of type []string` Subscribe parameter is array, not single string. You can verfiy it by decoding JWT in these official examples: 1. https://github.com/dunglas/mercure/blob/master/examples/publisher-php.php 2. https://github.com/dunglas/mercure/blob/master/hub/authorization_test.go Commits ------- c089b6e Fixed subscribe claim parameter set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you follow current guide and set claim mercure
subscribewith single string - you get following error from mercure:json: cannot unmarshal string into Go struct field mercureClaim.subscribe of type []stringSubscribe parameter is array, not single string.
You can verfiy it by decoding JWT in these official examples: