Skip to content

[Mime] Add "mime.mime_type_guesser" tag documentation #11906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2019
Merged

[Mime] Add "mime.mime_type_guesser" tag documentation #11906

merged 1 commit into from
Jul 8, 2019

Conversation

jschaedl
Copy link
Contributor

@jschaedl jschaedl commented Jul 7, 2019

No description provided.

OskarStark
OskarStark requested changes Jul 8, 2019
View reviewed changes
jschaedl
jschaedl commented Jul 8, 2019
View reviewed changes
@javiereguiluz javiereguiluz added this to the 4.3 milestone Jul 8, 2019
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jul 8, 2019
@javiereguiluz
minor symfony#11906 [Mime] Add "mime.mime_type_guesser" tag documenta…
4cea8aa 
…tion (jschaedl)

This PR was squashed before being merged into the 4.3 branch (closes symfony#11906).

Discussion
----------

[Mime] Add "mime.mime_type_guesser" tag documentation

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

316582f [Mime] Add \"mime.mime_type_guesser\" tag documentation
@javiereguiluz javiereguiluz merged commit 316582f into symfony:4.3 Jul 8, 2019
@javiereguiluz
Copy link
Member

Jan, thanks for this contribution! We reworded it a bit while merging (see edf6e5e) to avoid repeating some of the internal details of guessing MIME types which is already mentioned in the main Mime component docs.

@jschaedl
Copy link
Contributor Author

jschaedl commented Jul 8, 2019

Thanks @javiereguiluz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark requested changes

Assignees
No one assigned
Labels
Mime Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@jschaedl @javiereguiluz @OskarStark @carsonbot